Delphi XE and ShellExecute glitch

Just encountered a strange bug in one of my programs when running it from the Delphi XE IDE on Windows 10.

Triggering a TBrowseURL action with a valid URL property value causes the program to hang and the default browser (Chrome) is not displayed. The BeforeBrowse event is triggered, but AfterBrowse is not until the program is closed. Sometimes the program hangs and I have to close it with Ctrl+F2.

Running the same code outside the IDE works correctly, but running the program either with or without the debugger in the IDE makes no difference.

I've tracked this down to where TBrowseURL calls ShellExecute from the ShellAPI unit. If I call ShellExecute directly I get the same problem.

I never noticed this problem before when running Windows 7 on my old laptop - it just seems to have started on my new Windows 10 laptop. Still, it's possible the bug was still there on the old machine and I just never noticed it, but I doubt it.

Anyone else had this problem? Any ideas what may be causing it?

Comments

  1. Thomas Mueller10:04 am

    I know that one but never tracked it down. It occurred even on Windows XP for me sometimes.

    ReplyDelete
  2. Delphidabbler10:35 am

    Glad someone else has seen it. I was thinking I'd broken something!

    ReplyDelete
  3. Lars Fosdal2:43 pm

    Do you call CoInitialize before ShellExecute?
    CoInitializeEx(nil, COINIT_APARTMENTTHREADED or COINIT_DISABLE_OLE1DDE);

    ReplyDelete
  4. Delphidabbler8:13 pm

    I'm not sure if I did call CoInitialize - I'll check and try it if not.

    I know some parts of the code do call it, but there may (should) be a matching CoUnintialize to those calls.

    Thanks.

    ReplyDelete
  5. Lars Fosdal9:18 am

    The reason is that some shellexecutes may cause COM activation, and that will fail if you don't do CoInit/CoUnInit.
    I will be curious to see if it helps for your problem?

    ReplyDelete
  6. Delphidabbler11:53 am

    Tried calling CoInitializeEz as suggested Lars, both in FormCreate and FormDestroy for the main form and in the BeforeBrowser and AfterBrowse events of a TBrowseURL component and no luck - the program still hangs in the IDE when the action is triggered while it works fine when run outside the IDE.

    ReplyDelete
  7. Lars Fosdal2:24 pm

    Did you test the different threading models?

    ReplyDelete
  8. EMB7:08 pm

    The problem is in ShellExecute or it do really need a TWebBrowser to reproduce?

    ReplyDelete
  9. Delphidabbler10:49 pm

    Problem is in ShellExecute. I'm intercepting any links clicked in TWebBrowser and handling them myself.

    Haven't had chance to try any other threading models yet.

    ReplyDelete
  10. KeeperWorld5:20 pm

    Problem is in ShellExecute!!! This problem of SheelExecute - only in Windows 10. In XP, Windows7, Windows8 - everything is normal.... Who does that know how to correct it?

    ReplyDelete
  11. Delphidabbler3:40 am

    Glad it'snot me then!

    I'd also be interested in any solution.

    ReplyDelete
  12. Jose Ozuna2:49 pm

    the problem is, Delphi no convertion String Type to PChar is Wrong

    this code work fine on Windows 10 with Compile with delphi XE8

    var
    s : WideString;
    begin
    s := VariablePathString;
    ShellExecuteW(Handle, PWideChar('open'), PWideChar(s), nil, nil, SW_SHOWNORMAL);
    end;

    ReplyDelete
  13. Delphidabbler7:06 pm

    Thx

    I'll try that.

    ReplyDelete
  14. Tiger Jakt8:24 pm

    I am also facing a shellexecute glitch with XE5 in win7. Sometimes it executes sometimes crashes the application without executing an else error message block. I tried showmessage(path) each time. no problem with path each time but shellexecute becomes unpredictable.

    ReplyDelete
  15. Tiger Jakt8:26 pm

    Definitely from my showmessage experiments, I think the problem is with PChar() function as Jose points out. Let's see.

    ReplyDelete
  16. Anonymous3:33 pm

    nothing seems to work. resorted to use createprocess with commandline path to document.

    ReplyDelete

Post a Comment

Comments are very welcome, but please don't comment here if:

1) You have a query about, or a bug report for, one of my programs or libraries. Most of my posts contain a link to the relevant repository where there will be an issue tracker you can use.

2) You have a query about any 3rd party programs I feature, please address them to the developer(s) - there will be a link in the post.

3) You're one of the tiny, tiny minority who are aggressive or abusive - in the bin you go and reported you will be!

Thanks

Popular posts from this blog

Initialising dynamic arrays

When writing some unit tests a while ago I found myself needing to initialise some dynamic arrays with test data. It would be nice if we could do something like this: var A : array of Integer ; begin A := ( 1 , 2 , 3 , 4 ) ; // !! WRONG end ; but we can't. So I decided to write some functions to initialise dynamic arrays to the contents of another array, be it a constant, a literal or another dynamic array. The result was a set of overloaded routines, one for each data type I needed to handle, for example for Integer and string arrays I had: function CloneArray ( const A : array of Integer ) : TIntegerDynArray ; overload ; var Idx : Integer ; begin SetLength ( Result , Length ( A ) ) ; for Idx := Low ( A ) to High ( A ) do Result [ Idx - Low ( A ) ] := A [ Idx ] ; end ; function CloneArray ( const A : array of string ) : TStringDynArray ; overload ; var Idx : Integer ; begin SetLength ( Result , Len...
Read more

Deleting elements from a dynamic array

In my blog " Initialising Dynamic Arrays " I mentioned I have been writing some unit tests that needed numerous repetative array initialisation operations. Well, one of the other common operations I found myself writing was the deletion of items from dynamic arrays. So I decided to find a generic way of doing this. Assuming we know the index of the item to be deleted we need the equivalent of Delphi's built-in Delete procedure for strings. If you read the previous post you won't be surprised to learn that I decided to further extend the Generics.Collections.TArray class by adding to the TArrayEx class I introduced there. My first attempt emulates Delphi's Delete procedure by deleting the array element in-place: i.e. it updates the array passed as a parameter. Unsurprisingly the method is called DeleteInPlace . Here's how it goes: type TArrayEx = class ( TArray ) public .. . class procedure DeleteInPlace < T > ( var A : ...
Read more

New String Property Editor Planned For RAD Studio 12 Yukon 🤞

Image
This blog post is based on a pre-release version of the RAD Studio software and it has been written with specific permission by Embarcadero. No feature is committed until the product GA release. It seems I'm getting very excited about multi-line strings of late. My previous post was about multi-line string literals for Delphi  and this time I'm talking about the new multi-line string property editor being slated for the RAD Studio 12 IDE. For more years than I care to remember, I've been frustrated by the inability to enter multi-line strings in the Delphi IDE object inspector. That meant having to resort to code to initialise some multi-line labels. So frustrated was I that I wrote a little property editor of my own ( stringpe ), way back in 2004. It's still around and on GitHub. Here's what it (sometimes) looks like: Yeah, I know this is Vista - I used an old screenshot Sometimes? Well it looked like that until it got installed on DPI aware Delphis, and then it sh...
Read more