Hotfix available: CodeSnip bug fix fix

It had to happen didn't it? Not long after my post about yesterday's bug fix release of CodeSnip, Oliver reached out to point out a potential problem with the way I'd implemented it. See the linked post and comments if you're interested in the details.

Suffice to say that the problem was sufficient for me to hunt for an alternative solution. Having found one I've rushed out hotfix v4.24.2 to patch yesterday's release (v4.24.1) and make it more robust.

Whether or not you downloaded yesterday's you really should update CodeSnip to the hotfix release.

⮞ Get hotfix release v4.24.2 from GitHub.

For more info please see the similar post on the CodeSnip Blog.



Comments

  1. Oliver9:13 am

    The root cause of that bug is when a TreeView is recreated all Nodes save their state into a MemoryStream then they get destroyed and then recreated from that MemoryStream.

    My advice is to store the IView reference in the Data property of the TViewItemTreeNode Data := Pointer(Value); and back with Result := IView(Data);

    The management for the IView references goes to TOverviewFrame which keeps the references in a TList;

    TOverviewTreeBuilder will get a reference of that list and on Build it will clear the list and adds all IView references.

    I made a quick test on your source and it runs totally fine even after removing all of that hacking stuff ;o)

    Happy Easter

    ReplyDelete
    Replies
    1. Delphidabbler11:33 am

      Thanks for that Oliver. I was considering trying to use the Data property instead of the custom property in the derived custom tree node class.

      But I didn't consider casting the IView reference directly to Pointer, I thought I'd need to get at the underlying object through nefarious means! I guess that Pointer(IView) must use the pointer to the implementing object?

      I'll certainly try that. Many thanks. The reason I sub classed TTreeNode to add the IView property is because I don't like casting to Pointer, but it's certainly much cleaner code than the current fix!

      Given that the Easter bank holiday has brought its usual vile weather here in Wales, I don't want to be out and about, so should have some time to try this!

      Happy Easter to you too.

      Delete
    2. Delphidabbler12:19 pm

      Just in case you missed it on GitHub, your patch has been rolled into release v4.25.0. Thx again.

      Delete

Post a Comment

Comments are very welcome, but please don't comment here if:

1) You have a query about, or a bug report for, one of my programs or libraries. Most of my posts contain a link to the relevant repository where there will be an issue tracker you can use.

2) You have a query about any 3rd party programs I feature, please address them to the developer(s) - there will be a link in the post.

3) You're one of the tiny, tiny minority who are aggressive or abusive - in the bin you go and reported you will be!

Thanks

Popular posts from this blog

Initialising dynamic arrays

When writing some unit tests a while ago I found myself needing to initialise some dynamic arrays with test data. It would be nice if we could do something like this: var A : array of Integer ; begin A := ( 1 , 2 , 3 , 4 ) ; // !! WRONG end ; but we can't. So I decided to write some functions to initialise dynamic arrays to the contents of another array, be it a constant, a literal or another dynamic array. The result was a set of overloaded routines, one for each data type I needed to handle, for example for Integer and string arrays I had: function CloneArray ( const A : array of Integer ) : TIntegerDynArray ; overload ; var Idx : Integer ; begin SetLength ( Result , Length ( A ) ) ; for Idx := Low ( A ) to High ( A ) do Result [ Idx - Low ( A ) ] := A [ Idx ] ; end ; function CloneArray ( const A : array of string ) : TStringDynArray ; overload ; var Idx : Integer ; begin SetLength ( Result , Len...
Read more

Deleting elements from a dynamic array

In my blog " Initialising Dynamic Arrays " I mentioned I have been writing some unit tests that needed numerous repetative array initialisation operations. Well, one of the other common operations I found myself writing was the deletion of items from dynamic arrays. So I decided to find a generic way of doing this. Assuming we know the index of the item to be deleted we need the equivalent of Delphi's built-in Delete procedure for strings. If you read the previous post you won't be surprised to learn that I decided to further extend the Generics.Collections.TArray class by adding to the TArrayEx class I introduced there. My first attempt emulates Delphi's Delete procedure by deleting the array element in-place: i.e. it updates the array passed as a parameter. Unsurprisingly the method is called DeleteInPlace . Here's how it goes: type TArrayEx = class ( TArray ) public .. . class procedure DeleteInPlace < T > ( var A : ...
Read more